@Yoni-Starkware reviewed 2 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @avi-starkware, @AvivYossef-starkware, and @noaov1).

crates/blockifier/src/execution/contract_class_test.rs line 266 at r1 (raw file):

    let round_tripped_hints = program_hints_to_casm_hints(program_hints).unwrap();

    // Compare with original (need to sort both for comparison).

I don't see any sort here

Code quote:

(need to sort both for comparison).

@AvivYossef-starkware made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @avi-starkware, @noaov1, and @Yoni-Starkware).

crates/blockifier/src/execution/contract_class_test.rs line 266 at r1 (raw file):

they are both sorted the same ( with the Btree map )

@avi-starkware reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @AvivYossef-starkware, @noaov1, and @Yoni-Starkware).

crates/blockifier/src/execution/contract_class.rs line 722 at r2 (raw file):

pub fn program_hints_to_casm_hints(
    program_hints: &HintsCollection,
) -> Result<Vec<(usize, Vec<Hint>)>, ProgramError> {

consider defining a CasmHintsCollection type as Vec<(usize, Vec<Hint>) and defining this function as the impl of From<HintsCollection>.

Code quote:

) -> Result<Vec<(usize, Vec<Hint>)>, ProgramError> {

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @AvivYossef-starkware, @noaov1, and @Yoni-Starkware).